Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serviceaccount): update regex pattern for description #552

Conversation

craicoverflow
Copy link
Contributor

@craicoverflow craicoverflow commented Apr 9, 2021

Follows up to bf2fc6cc711aee1a0c2a/kas-fleet-manager#172

Verification Steps

Create a service account with a description with ",", ".", "-" characters.
It should get created.

$ rhoas serviceaccount create --name "test" --overwrite --file-format env --description "Hello...- ,"

Service account "test" created successfully with ID "55f8d0ed-783d-4af9-b284-019791425da5".
Credentials saved to /home/ephelan/code/github.com/redhat-developer/app-services-cli/.env

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@craicoverflow craicoverflow force-pushed the serviceaccount-description-regex branch from 6345a48 to 8bb60e5 Compare April 9, 2021 16:15
@craicoverflow craicoverflow marked this pull request as ready for review April 12, 2021 07:38
@craicoverflow craicoverflow merged commit 4268bae into redhat-developer:main Apr 12, 2021
@craicoverflow craicoverflow deleted the serviceaccount-description-regex branch April 12, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant